Skip to content

Commit 32260b9

Browse files
danbevMylesBorins
authored andcommitted
test: check crypto before requiring tls module
test-tls-session-cache currently fails if built --without-ssl: internal/util.js:82 throw new errors.Error('ERR_NO_CRYPTO'); ^ Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support at Object.assertCrypto (internal/util.js:82:11) at tls.js:26:14 at NativeModule.compile (bootstrap_node.js:586:7) at Function.NativeModule.require (bootstrap_node.js:531:18) at Function.Module._load (module.js:449:25) at Module.require (module.js:517:17) at require (internal/module.js:11:18) at Object.<anonymous> (/node/test/parallel/test-tls-session-cache.js:26:13) at Module._compile (module.js:573:30) at Object.Module._extensions..js (module.js:584:10) The test has a crypto check but it come after the require of the tls module. This commit moves the crypto check to come before the require of tls and allows the test to pass. PR-URL: #14708 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: David Cai <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 68cf7f0 commit 32260b9

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

test/parallel/test-tls-session-cache.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
'use strict';
22
const common = require('../common');
33

4-
if (!common.opensslCli)
5-
common.skip('node compiled without OpenSSL CLI.');
6-
74
if (!common.hasCrypto)
85
common.skip('missing crypto');
96

7+
if (!common.opensslCli)
8+
common.skip('node compiled without OpenSSL CLI.');
9+
1010
const assert = require('assert');
1111
const tls = require('tls');
1212
const fs = require('fs');

0 commit comments

Comments
 (0)