Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 32628e0

Browse files
Trottevanlucas
authored andcommittedApr 25, 2017
doc: update link for landing PRs
The onboarding doc links to the "Technical How-to" portion of the Collaborator's Guide for landing PRs. That section is a subsection of the "Landing Pull Requests" portion of that document. By skipping the main section header, important information is skipped, such as the part about not using the merge button and descriptions of the metadata required. Update the link to target the main section and not the subsection. PR-URL: #12415 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
1 parent 5b9bf19 commit 32628e0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎doc/onboarding.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ onboarding session.
132132

133133
## Landing PRs
134134

135-
* [See the Collaborator Guide: Technical HOWTO](https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#technical-howto)
135+
* [See the Collaborator Guide: Landing Pull Requests](https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#landing-pull-requests)
136136

137137
## Exercise: Make a PR adding yourself to the README
138138

0 commit comments

Comments
 (0)
Please sign in to comment.