Skip to content

Commit 326d19a

Browse files
tniessenRafaelGSS
authored andcommitted
src: resolve TODO related to inspector CVEs
This was not done before the security release because the latest CVE was not known at the time. PR-URL: #45341 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent 0deed8d commit 326d19a

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/inspector_socket.cc

+3-4
Original file line numberDiff line numberDiff line change
@@ -162,11 +162,10 @@ static std::string TrimPort(const std::string& host) {
162162
}
163163

164164
static bool IsIPAddress(const std::string& host) {
165-
// TODO(tniessen): add CVEs to the following bullet points
166165
// To avoid DNS rebinding attacks, we are aware of the following requirements:
167-
// * the host name must be an IP address,
168-
// * the IP address must be routable, and
169-
// * the IP address must be formatted unambiguously.
166+
// * the host name must be an IP address (CVE-2018-7160, CVE-2022-32212),
167+
// * the IP address must be routable (hackerone.com/reports/1632921), and
168+
// * the IP address must be formatted unambiguously (CVE-2022-43548).
170169

171170
// The logic below assumes that the string is null-terminated, so ensure that
172171
// we did not somehow end up with null characters within the string.

0 commit comments

Comments
 (0)