Skip to content

Commit 335b61a

Browse files
committed
test: skip node-api/test_worker_terminate_finalization
The test fails under ASAN/valgrind. Since it has not been working properly until today anyway, skip it. Refs: #34731 PR-URL: #34732 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
1 parent b28a6a5 commit 335b61a

File tree

1 file changed

+5
-0
lines changed
  • test/node-api/test_worker_terminate_finalization

1 file changed

+5
-0
lines changed

test/node-api/test_worker_terminate_finalization/test.js

+5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
'use strict';
22
const common = require('../../common');
3+
4+
// TODO(addaleax): Run this test once it stops failing under ASAN/valgrind.
5+
// Refs: https://github.com/nodejs/node/issues/34731
6+
common.skip('Reference management in N-API leaks memory');
7+
38
const { Worker, isMainThread } = require('worker_threads');
49

510
if (isMainThread) {

0 commit comments

Comments
 (0)