Skip to content

Commit 339d220

Browse files
sam-githubjasnell
authored andcommitted
test: rearrange inspector headers into convention
Test guide describes a conventional layout for test headers, review inspector tests and reorganize to follow the convention. PR-URL: #13428 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 6aeb555 commit 339d220

8 files changed

+16
-5
lines changed

test/inspector/test-inspector-debug-brk.js

+2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
'use strict';
22
const common = require('../common');
3+
34
common.skipIfInspectorDisabled();
5+
46
const assert = require('assert');
57
const helper = require('./inspector-helper.js');
68

test/inspector/test-inspector-ip-detection.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
'use strict';
22
const common = require('../common');
3+
34
common.skipIfInspectorDisabled();
45

56
const assert = require('assert');

test/inspector/test-inspector-port-zero-cluster.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
// Flags: --inspect=0
22
'use strict';
3-
43
const common = require('../common');
4+
55
common.skipIfInspectorDisabled();
6+
67
const assert = require('assert');
78
const cluster = require('cluster');
89

test/inspector/test-inspector-port-zero.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
'use strict';
2-
32
const { mustCall, skipIfInspectorDisabled } = require('../common');
3+
44
skipIfInspectorDisabled();
5+
56
const assert = require('assert');
67
const { URL } = require('url');
78
const { spawn } = require('child_process');

test/inspector/test-inspector-stops-no-file.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
'use strict';
22
require('../common');
3+
34
const spawn = require('child_process').spawn;
45

56
const child = spawn(process.execPath,

test/inspector/test-inspector.js

+2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
'use strict';
22
const common = require('../common');
3+
34
common.skipIfInspectorDisabled();
5+
46
const assert = require('assert');
57
const helper = require('./inspector-helper.js');
68

test/parallel/test-cluster-inspector-debug-port.js

+2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
'use strict';
22
// Flags: --inspect={PORT}
33
const common = require('../common');
4+
45
common.skipIfInspectorDisabled();
6+
57
const assert = require('assert');
68
const cluster = require('cluster');
79
const debuggerPort = common.PORT;

test/parallel/test-inspector-invalid-args.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
'use strict';
2+
const common = require('../common');
3+
4+
common.skipIfInspectorDisabled();
5+
26
const assert = require('assert');
37
const execFile = require('child_process').execFile;
48
const path = require('path');
59

6-
const common = require('../common');
7-
common.skipIfInspectorDisabled();
8-
910
const mainScript = path.join(common.fixturesDir, 'loop.js');
1011
const expected =
1112
'`node --debug` and `node --debug-brk` are invalid. ' +

0 commit comments

Comments
 (0)