Skip to content

Commit 3663ac2

Browse files
Trottjasnell
authored andcommitted
test: remove flaky designation for test on AIX
#5085 has been completed so presumably test-fs-watch is not flaky on AIX anymore. Remove flaky designation from sequential.status. PR-URL: #12564 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
1 parent 9cc39ff commit 3663ac2

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

test/sequential/sequential.status

-5
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,4 @@ test-benchmark-child-process : PASS,FLAKY
1717

1818
[$system==freebsd]
1919

20-
# fs-watch currently needs special configuration on AIX and we
21-
# want to improve under https://github.com/nodejs/node/issues/5085.
22-
# Tests are disabled so CI can be green and we can spot other
23-
# regressions until this work is complete
2420
[$system==aix]
25-
test-fs-watch : FAIL,PASS

test/sequential/test-fs-watch.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ const fs = require('fs');
2727

2828
const expectFilePath = common.isWindows ||
2929
common.isLinux ||
30-
common.isOSX;
30+
common.isOSX ||
31+
common.isAix;
3132

3233
let watchSeenOne = 0;
3334
let watchSeenTwo = 0;
@@ -101,7 +102,7 @@ const filepathThree = path.join(testsubdir, filenameThree);
101102
assert.doesNotThrow(
102103
function() {
103104
const watcher = fs.watch(testsubdir, function(event, filename) {
104-
const renameEv = common.isSunOS ? 'change' : 'rename';
105+
const renameEv = common.isSunOS || common.isAix ? 'change' : 'rename';
105106
assert.strictEqual(renameEv, event);
106107
if (expectFilePath) {
107108
assert.strictEqual('newfile.txt', filename);

0 commit comments

Comments
 (0)