Skip to content

Commit 36a026b

Browse files
kvakiltargos
authored andcommitted
src: remove dead comments about return_code_cache
This behavior of sometimes returning the function & other times returning the code cache was removed a long time ago in the referenced PR, as evinced by the return type `MaybeLocal<Function>`. Remove these incorrect comments. Refs: #24950 PR-URL: #47083 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
1 parent d6a1232 commit 36a026b

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

src/node_builtins.cc

-6
Original file line numberDiff line numberDiff line change
@@ -256,9 +256,6 @@ bool BuiltinLoader::Add(const char* id, std::string_view utf8source) {
256256
return Add(id, UnionBytes(out));
257257
}
258258

259-
// Returns Local<Function> of the compiled module if return_code_cache
260-
// is false (we are only compiling the function).
261-
// Otherwise return a Local<Object> containing the cache.
262259
MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal(
263260
Local<Context> context,
264261
const char* id,
@@ -356,9 +353,6 @@ MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal(
356353
return scope.Escape(fun);
357354
}
358355

359-
// Returns Local<Function> of the compiled module if return_code_cache
360-
// is false (we are only compiling the function).
361-
// Otherwise return a Local<Object> containing the cache.
362356
MaybeLocal<Function> BuiltinLoader::LookupAndCompile(Local<Context> context,
363357
const char* id,
364358
Realm* optional_realm) {

0 commit comments

Comments
 (0)