Skip to content

Commit 375994f

Browse files
Eugene OstroukhovMylesBorins
Eugene Ostroukhov
authored andcommitted
inspector: Use default uv_listen backlog size
PR-URL: #20254 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
1 parent b5c1c14 commit 375994f

File tree

2 files changed

+36
-1
lines changed

2 files changed

+36
-1
lines changed

src/inspector_socket_server.cc

+2-1
Original file line numberDiff line numberDiff line change
@@ -587,7 +587,8 @@ int ServerSocket::Listen(InspectorSocketServer* inspector_server,
587587
CHECK_EQ(0, uv_tcp_init(loop, server));
588588
int err = uv_tcp_bind(server, addr, 0);
589589
if (err == 0) {
590-
err = uv_listen(reinterpret_cast<uv_stream_t*>(server), 1,
590+
// 511 is the value used by a 'net' module by default
591+
err = uv_listen(reinterpret_cast<uv_stream_t*>(server), 511,
591592
ServerSocket::SocketConnectedCallback);
592593
}
593594
if (err == 0) {
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
// Flags: --expose-internals
2+
'use strict';
3+
const common = require('../common');
4+
5+
common.skipIfInspectorDisabled();
6+
7+
const assert = require('assert');
8+
const { NodeInstance } = require('../common/inspector-helper.js');
9+
10+
async function testHttp(child, number) {
11+
try {
12+
await child.httpGet(null, '/json/list');
13+
return true;
14+
} catch (e) {
15+
console.error(`Attempt ${number} failed`, e);
16+
return false;
17+
}
18+
}
19+
20+
async function runTest() {
21+
const child = new NodeInstance(undefined, '');
22+
23+
const promises = [];
24+
for (let i = 0; i < 100; i++) {
25+
promises.push(testHttp(child, i));
26+
}
27+
const result = await Promise.all(promises);
28+
assert(!result.some((a) => !a), 'Some attempts failed');
29+
return child.kill();
30+
}
31+
32+
common.crashOnUnhandledRejection();
33+
34+
runTest();

0 commit comments

Comments
 (0)