Skip to content

Commit 383d809

Browse files
bzoztargos
authored andcommitted
build, tools, win: add .S files support to GYP
Makes GYP properly handle .S files. Fixes: nodejs/node-v8#89 PR-URL: #24553 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
1 parent 899e7c3 commit 383d809

File tree

1 file changed

+2
-1
lines changed
  • tools/gyp/pylib/gyp/generator

1 file changed

+2
-1
lines changed

tools/gyp/pylib/gyp/generator/msvs.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -2156,6 +2156,7 @@ def _MapFileToMsBuildSourceType(source, rule_dependencies,
21562156
A pair of (group this file should be part of, the label of element)
21572157
"""
21582158
_, ext = os.path.splitext(source)
2159+
ext = ext.lower()
21592160
if ext in extension_to_rule_name:
21602161
group = 'rule'
21612162
element = extension_to_rule_name[ext]
@@ -2168,7 +2169,7 @@ def _MapFileToMsBuildSourceType(source, rule_dependencies,
21682169
elif ext == '.rc':
21692170
group = 'resource'
21702171
element = 'ResourceCompile'
2171-
elif ext == '.asm':
2172+
elif ext in ['.s', '.asm']:
21722173
group = 'masm'
21732174
element = 'MASM'
21742175
elif ext == '.idl':

0 commit comments

Comments
 (0)