Skip to content

Commit 38e0f95

Browse files
danbevMylesBorins
authored andcommitted
build: add MAKEFLAGS="-j1" to node-gyp
Currently, when building the addons the following warning is displayed: make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. Adding the MAKEFLAGS="-j1" to avoid the warning. Also updated the log message to say that it is building the addon and not running the test as I think that is more accurate. PR-URL: #9450 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent d1b6407 commit 38e0f95

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

Diff for: Makefile

+4-3
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,10 @@ test/addons/.buildstamp: config.gypi \
150150
$(ADDONS_BINDING_GYPS) test/addons/.docbuildstamp
151151
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before
152152
# embedded addons have been generated from the documentation.
153-
for dirname in test/addons/*/; do \
154-
echo "\nRunning addons test $$PWD/$$dirname" ; \
155-
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp --loglevel=$(LOGLEVEL) rebuild \
153+
@for dirname in test/addons/*/; do \
154+
echo "\nBuilding addon $$PWD/$$dirname" ; \
155+
env MAKEFLAGS="-j1" $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp \
156+
--loglevel=$(LOGLEVEL) rebuild \
156157
--python="$(PYTHON)" \
157158
--directory="$$PWD/$$dirname" \
158159
--nodedir="$$PWD"; \

0 commit comments

Comments
 (0)