Skip to content

Commit 3906206

Browse files
mscdexMylesBorins
authored andcommitted
net: remove unnecessary variables
V8 is smart enough to optimize the length property checking when iterating over an array with a for loop. PR-URL: #8112 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent b063dc9 commit 3906206

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

lib/net.js

+4-6
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,8 @@ exports.createServer = function(options, connectionListener) {
5959
// connect(path, [cb]);
6060
//
6161
exports.connect = exports.createConnection = function() {
62-
const argsLen = arguments.length;
63-
var args = new Array(argsLen);
64-
for (var i = 0; i < argsLen; i++)
62+
var args = new Array(arguments.length);
63+
for (var i = 0; i < arguments.length; i++)
6564
args[i] = arguments[i];
6665
args = normalizeConnectArgs(args);
6766
debug('createConnection', args);
@@ -875,9 +874,8 @@ Socket.prototype.connect = function(options, cb) {
875874
// Old API:
876875
// connect(port, [host], [cb])
877876
// connect(path, [cb]);
878-
const argsLen = arguments.length;
879-
var args = new Array(argsLen);
880-
for (var i = 0; i < argsLen; i++)
877+
var args = new Array(arguments.length);
878+
for (var i = 0; i < arguments.length; i++)
881879
args[i] = arguments[i];
882880
args = normalizeConnectArgs(args);
883881
return Socket.prototype.connect.apply(this, args);

0 commit comments

Comments
 (0)