Skip to content

Commit 39834bc

Browse files
addaleaxjasnell
authored andcommitted
v8: backport pieces of 6226576efa82ee
Backport removed methods from 6226576efa82ee (β€œ[wasm] Deleted old way of checking embedder limits on wasm size.”). Ref: https://codereview.chromium.org/2772203005 Ref: v8/v8@6226576efa82ee PR-URL: #12875 Reviewed-By: James M Snell <[email protected]>
1 parent 25430fd commit 39834bc

File tree

2 files changed

+0
-21
lines changed

2 files changed

+0
-21
lines changed

β€Ždeps/v8/include/v8.h

-10
Original file line numberDiff line numberDiff line change
@@ -7154,16 +7154,6 @@ class V8_EXPORT Isolate {
71547154
void SetAllowCodeGenerationFromStringsCallback(
71557155
AllowCodeGenerationFromStringsCallback callback);
71567156

7157-
/**
7158-
* Set the callback to invoke to check if wasm compilation from
7159-
* the specified object is allowed. By default, wasm compilation
7160-
* is allowed.
7161-
*
7162-
* Similar for instantiate.
7163-
*/
7164-
void SetAllowWasmCompileCallback(AllowWasmCompileCallback callback);
7165-
void SetAllowWasmInstantiateCallback(AllowWasmInstantiateCallback callback);
7166-
71677157
/**
71687158
* Check if V8 is dead and therefore unusable. This is the case after
71697159
* fatal errors such as out-of-memory situations.

β€Ždeps/v8/src/api.cc

-11
Original file line numberDiff line numberDiff line change
@@ -8658,17 +8658,6 @@ void Isolate::SetAllowCodeGenerationFromStringsCallback(
86588658
isolate->set_allow_code_gen_callback(callback);
86598659
}
86608660

8661-
void Isolate::SetAllowWasmCompileCallback(AllowWasmCompileCallback callback) {
8662-
i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this);
8663-
isolate->set_allow_wasm_compile_callback(callback);
8664-
}
8665-
8666-
void Isolate::SetAllowWasmInstantiateCallback(
8667-
AllowWasmInstantiateCallback callback) {
8668-
i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this);
8669-
isolate->set_allow_wasm_instantiate_callback(callback);
8670-
}
8671-
86728661
bool Isolate::IsDead() {
86738662
i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this);
86748663
return isolate->IsDead();

0 commit comments

Comments
Β (0)