Skip to content

Commit 3a682cc

Browse files
HBSPSmarco-ippolito
authored andcommitted
path: remove repetitive conditional operator in posix.resolve
PR-URL: #54835 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent a730cdb commit 3a682cc

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

lib/path.js

+9-2
Original file line numberDiff line numberDiff line change
@@ -1164,8 +1164,8 @@ const posix = {
11641164
let resolvedPath = '';
11651165
let resolvedAbsolute = false;
11661166

1167-
for (let i = args.length - 1; i >= -1 && !resolvedAbsolute; i--) {
1168-
const path = i >= 0 ? args[i] : posixCwd();
1167+
for (let i = args.length - 1; i >= 0 && !resolvedAbsolute; i--) {
1168+
const path = args[i];
11691169
validateString(path, `paths[${i}]`);
11701170

11711171
// Skip empty entries
@@ -1178,6 +1178,13 @@ const posix = {
11781178
StringPrototypeCharCodeAt(path, 0) === CHAR_FORWARD_SLASH;
11791179
}
11801180

1181+
if (!resolvedAbsolute) {
1182+
const cwd = posixCwd();
1183+
resolvedPath = `${cwd}/${resolvedPath}`;
1184+
resolvedAbsolute =
1185+
StringPrototypeCharCodeAt(cwd, 0) === CHAR_FORWARD_SLASH;
1186+
}
1187+
11811188
// At this point the path should be resolved to a full absolute path, but
11821189
// handle relative paths to be safe (might happen when process.cwd() fails)
11831190

0 commit comments

Comments
 (0)