You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds documentation and explicit reasons on why
the GitHub web interface button is not used. This was
explained in the referenced issue by @thealphanerd.
Fixes: #8893
PR-URL: #9044
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Copy file name to clipboardexpand all lines: doc/onboarding.md
+8-1
Original file line number
Diff line number
Diff line change
@@ -164,8 +164,15 @@ onboarding session.
164
164
165
165
## Landing PRs: Details
166
166
167
-
* Please never use GitHub's green "Merge Pull Request" button.
167
+
* Please never use GitHub's green ["Merge Pull Request"](https://help.github.com/articles/merging-a-pull-request/#merging-a-pull-request-using-the-github-web-interface) button.
168
168
* If you do, please force-push removing the merge.
169
+
* Reasons for not using the web interface button:
170
+
* The merge method will add an unnecessary merge commit.
171
+
* The rebase & merge method adds metadata to the commit title.
172
+
* The rebase method changes the author.
173
+
* The squash & merge method has been known to add metadata to the commit title.
174
+
* If more than one author has contributed to the PR, only the latest author will be considered during the squashing.
175
+
169
176
170
177
Update your `master` branch (or whichever branch you are landing on, almost always `master`)
0 commit comments