Skip to content

Commit 3b51617

Browse files
Benjamin CoeMylesBorins
Benjamin Coe
authored andcommitted
build: use nyc's merge command
a 'merge' command has recently been added to nyc, eliminating the need for the istanbul-merge library. PR-URL: #20760 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent 338e663 commit 3b51617

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

Makefile

+3-5
Original file line numberDiff line numberDiff line change
@@ -165,8 +165,6 @@ coverage: coverage-test ## Run the tests and generate a coverage report.
165165
.PHONY: coverage-build
166166
coverage-build: all
167167
mkdir -p node_modules
168-
if [ ! -d node_modules/istanbul-merge ]; then \
169-
$(NODE) ./deps/npm install istanbul-merge --no-save --no-package-lock; fi
170168
if [ ! -d node_modules/nyc ]; then \
171169
$(NODE) ./deps/npm install nyc --no-save --no-package-lock; fi
172170
if [ ! -d gcovr ]; then git clone -b 3.4 --depth=1 \
@@ -195,11 +193,11 @@ coverage-test: coverage-build
195193
mv lib lib__
196194
mv lib_ lib
197195
mkdir -p coverage .cov_tmp
198-
$(NODE) ./node_modules/.bin/istanbul-merge --out \
199-
.cov_tmp/libcov.json 'out/Release/.coverage/coverage-*.json'
196+
$(NODE) ./node_modules/.bin/nyc merge 'out/Release/.coverage' \
197+
.cov_tmp/libcov.json
200198
(cd lib && .$(NODE) ../node_modules/.bin/nyc report \
201199
--temp-directory "$(CURDIR)/.cov_tmp" \
202-
--report-dir "../coverage")
200+
--report-dir "$(CURDIR)/coverage")
203201
-(cd out && "../gcovr/scripts/gcovr" --gcov-exclude='.*deps' \
204202
--gcov-exclude='.*usr' -v -r Release/obj.target \
205203
--html --html-detail -o ../coverage/cxxcoverage.html \

0 commit comments

Comments
 (0)