Skip to content

Commit 3daced7

Browse files
Trotttargos
authored andcommitted
doc: remove "make that" from onboarding.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent 79f23b5 commit 3daced7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

doc/onboarding.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ onboarding session.
124124
* Be aware: Your opinion carries a lot of weight!
125125
* Nits (requests for small changes that are not essential) are fine, but try to
126126
avoid stalling the pull request.
127-
* Note that they are nits when you comment: `Nit: change foo() to bar().`
127+
* Identify them as nits when you comment: `Nit: change foo() to bar().`
128128
* If they are stalling the pull request, fix them yourself on merge.
129129
* Insofar as possible, issues should be identified by tools rather than human
130130
reviewers. If you are leaving comments about issues that could be identified
@@ -191,7 +191,7 @@ onboarding session.
191191

192192
See the Collaborator Guide: [Landing Pull Requests][].
193193

194-
Note that commits in one PR that belong to one logical change should
194+
Commits in one PR that belong to one logical change should
195195
be squashed. It is rarely the case in onboarding exercises, so this
196196
needs to be pointed out separately during the onboarding.
197197

0 commit comments

Comments
 (0)