Skip to content

Commit 3e4af49

Browse files
Masashi Hiranotargos
Masashi Hirano
authored andcommitted
test: add dns.onlookupall() to increase coverage
Added test that callback should be called when error occurs in dns.lookupall(). PR-URL: #22985 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent d68dfa9 commit 3e4af49

File tree

1 file changed

+17
-1
lines changed

1 file changed

+17
-1
lines changed

test/internet/test-dns-lookup.js

+17-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
'use strict';
22

33
require('../common');
4-
const dnsPromises = require('dns').promises;
4+
const common = require('../common');
5+
const dns = require('dns');
6+
const dnsPromises = dns.promises;
57
const { addresses } = require('../common/internet');
68
const assert = require('assert');
79

@@ -28,3 +30,17 @@ assert.rejects(
2830
message: `getaddrinfo ENOTFOUND ${addresses.INVALID_HOST}`
2931
}
3032
);
33+
34+
dns.lookup(addresses.INVALID_HOST, {
35+
hints: 0,
36+
family: 0,
37+
all: true
38+
}, common.mustCall((error) => {
39+
assert.strictEqual(error.code, 'ENOTFOUND');
40+
assert.strictEqual(
41+
error.message,
42+
`getaddrinfo ENOTFOUND ${addresses.INVALID_HOST}`
43+
);
44+
assert.strictEqual(error.syscall, 'getaddrinfo');
45+
assert.strictEqual(error.hostname, addresses.INVALID_HOST);
46+
}));

0 commit comments

Comments
 (0)