Skip to content

Commit 3ec3c32

Browse files
BufoViridisMylesBorins
authored andcommitted
src: fix crypto.pbkdf2 callback error argument
Callbacks should always return `null` instead of `undefined` if no error occurred. PR-URL: #18458 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent e8a75ee commit 3ec3c32

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/node_crypto.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -5599,7 +5599,7 @@ void PBKDF2Request::Work(uv_work_t* work_req) {
55995599

56005600
void PBKDF2Request::After(Local<Value> (*argv)[2]) {
56015601
if (success_) {
5602-
(*argv)[0] = Undefined(env()->isolate());
5602+
(*argv)[0] = Null(env()->isolate());
56035603
(*argv)[1] = Buffer::New(env(), key_, keylen_).ToLocalChecked();
56045604
key_ = nullptr;
56055605
keylen_ = 0;

0 commit comments

Comments
 (0)