Skip to content

Commit 3ed0499

Browse files
richardlautargos
authored andcommitted
build: shorten path used in tarball build workflow
Shorten the path to the workspace for the GitHub Actions `build-tarball` workflow to avoid `execvp: printf: Argument list too long` errors from `make`. GitHub currently runs workflows in a `/home/runner/work/my-repo/my-repo` directory where `my-repo` is the repository name and is repeated twice (the second is from the git checkout). Some of the command lines in the Node.js build, e.g. the `ar` command to create static libraries, pass several fully qualified paths to filenames so the workflow directory is repeat many times. The most recent V8 update added more files to the command and has now tipped the command line length over the maximum allowed when using forks of the `node` repository with a longer name (e.g. `node-auto-test` and the private fork used to prepare security releases). Use GitHub's `RUNNER_TEMP` environment variable to extract the source tarball into the temporary directory on the GitHub runner. This is currently `/home/runner/work/_temp` and is not dependent on the name of the repository. PR-URL: #39192 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 04bcfcf commit 3ed0499

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: .github/workflows/build-tarball.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ jobs:
5858
name: tarballs
5959
- name: Extract tarball
6060
run: |
61-
tar xzf tarballs/*.tar.gz
62-
echo "TAR_DIR=`basename tarballs/*.tar.gz .tar.gz`" >> $GITHUB_ENV
61+
tar xzf tarballs/*.tar.gz -C $RUNNER_TEMP
62+
echo "TAR_DIR=$RUNNER_TEMP/`basename tarballs/*.tar.gz .tar.gz`" >> $GITHUB_ENV
6363
- name: Copy directories needed for testing
6464
run: |
6565
cp -r tools/node_modules $TAR_DIR/tools

0 commit comments

Comments
 (0)