Skip to content

Commit 3fa5d80

Browse files
committed
benchmark: chunky http client should exit with 0
Previously when there is an error in the chunky client of the http benchmark, the server would not check the exit code and thus produce invalid results. PR-URL: #12916 Fixes: #12903 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 98609fc commit 3fa5d80

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

benchmark/http/http_server_for_chunky_client.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
'use strict';
22

3+
var assert = require('assert');
34
var path = require('path');
45
var http = require('http');
56
var fs = require('fs');
@@ -37,6 +38,7 @@ server.listen(PIPE);
3738

3839
var child = fork(pep, process.argv.slice(2));
3940
child.on('message', common.sendResult);
40-
child.on('close', function() {
41+
child.on('close', function(code) {
4142
server.close();
43+
assert.strictEqual(code, 0);
4244
});

0 commit comments

Comments
 (0)