Skip to content

Commit 3fc25dc

Browse files
Trottevanlucas
authored andcommitted
doc: run tests before landing changes
The Collaborator Guide suggests running tests after pushing changes to the main repository. Tests should be run before then so move the instructions earlier. Instructions are also simplified and re-written to not exclude Windows. PR-URL: #12416 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
1 parent af0067c commit 3fc25dc

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

COLLABORATOR_GUIDE.md

+4-5
Original file line numberDiff line numberDiff line change
@@ -445,6 +445,10 @@ commit logs, ensure that they are properly formatted, and add
445445
* The commit message text must conform to the
446446
[commit message guidelines](./CONTRIBUTING.md#step-3-commit).
447447

448+
Run tests (`make -j4 test` or `vcbuild test`). Even though there was a
449+
successful continuous integration run, other changes may have landed on master
450+
since then, so running the tests one last time locally is a good practice.
451+
448452
Time to push it:
449453

450454
```text
@@ -463,11 +467,6 @@ your pull request shows the purple merged status then you should still
463467
add the "Landed in <commit hash>..<commit hash>" comment if you added
464468
multiple commits.
465469

466-
* `./configure && make -j8 test`
467-
* `-j8` builds node in parallel with 8 threads. Adjust to the number
468-
of cores or processor-level threads your processor has (or slightly
469-
more) for best results.
470-
471470
### I Just Made a Mistake
472471

473472
* Ping a CTC member.

0 commit comments

Comments
 (0)