Skip to content

Commit 403c45f

Browse files
danbevMylesBorins
authored andcommitted
src: only call FatalException if not verbose
This commit attempts to address the TODO regarding not calling FatalException if the try_catch is verbose. PR-URL: #12826 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
1 parent 7fed989 commit 403c45f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/node.cc

+3-3
Original file line numberDiff line numberDiff line change
@@ -2602,9 +2602,9 @@ void FatalException(Isolate* isolate,
26022602

26032603
void FatalException(Isolate* isolate, const TryCatch& try_catch) {
26042604
HandleScope scope(isolate);
2605-
// TODO(bajtos) do not call FatalException if try_catch is verbose
2606-
// (requires V8 API to expose getter for try_catch.is_verbose_)
2607-
FatalException(isolate, try_catch.Exception(), try_catch.Message());
2605+
if (!try_catch.IsVerbose()) {
2606+
FatalException(isolate, try_catch.Exception(), try_catch.Message());
2607+
}
26082608
}
26092609

26102610

0 commit comments

Comments
 (0)