Skip to content

Commit 410e083

Browse files
joaocgreisMylesBorins
authored andcommitted
win,build: forward release_urlbase to configure
The RELEASE_URLBASE environment variable is used in releases as a prefix for links in the process.release object. The Makefile picks it and forwards it to configure, but vcbuild.bat did not. Hence, in Windows, Node releases have a correct process.release because it uses the default URL, but nightlies, RCs and so on do not, breaking node-gyp. This enables native modules to be built with such versions of Node. PR-URL: #8430 Reviewed-By: jbergstroem - Johan Bergström <[email protected]>
1 parent 26e7374 commit 410e083

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

vcbuild.bat

+1-2
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ set noperfctr=
3333
set noperfctr_msi_arg=
3434
set i18n_arg=
3535
set download_arg=
36-
set release_urls_arg=
3736
set build_release=
3837
set configure_flags=
3938
set build_addons=
@@ -104,7 +103,7 @@ if "%config%"=="Debug" set configure_flags=%configure_flags% --debug
104103
if defined nosnapshot set configure_flags=%configure_flags% --without-snapshot
105104
if defined noetw set configure_flags=%configure_flags% --without-etw& set noetw_msi_arg=/p:NoETW=1
106105
if defined noperfctr set configure_flags=%configure_flags% --without-perfctr& set noperfctr_msi_arg=/p:NoPerfCtr=1
107-
if defined release_urlbase set release_urlbase_arg=--release-urlbase=%release_urlbase%
106+
if defined release_urlbase set configure_flags=%configure_flags% --release-urlbase=%release_urlbase%
108107
if defined download_arg set configure_flags=%configure_flags% %download_arg%
109108

110109
if "%i18n_arg%"=="full-icu" set configure_flags=%configure_flags% --with-intl=full-icu

0 commit comments

Comments
 (0)