Skip to content

Commit 428b967

Browse files
bnoordhuisdanielleadams
authored andcommitted
build: remove broken x32 arch support
I added support for x32 back in 2014 but it's been in a state of disrepair ever since, not in the least because it was never a fully supported architecture in upstream V8. V8 dropped x32 support entirely in or around 2018 so the removal from Node's build system is long overdue. Refs: #40576 PR-URL: #41905 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
1 parent 11e76fc commit 428b967

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

72 files changed

+2907
-776
lines changed

common.gypi

+1-5
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@
112112
'v8_base': '<(PRODUCT_DIR)/libv8_snapshot.a',
113113
}],
114114
# V8 pointer compression only supports 64bit architectures.
115-
['target_arch in "arm ia32 mips mipsel ppc x32"', {
115+
['target_arch in "arm ia32 mips mipsel ppc"', {
116116
'v8_enable_pointer_compression': 0,
117117
'v8_enable_31bit_smis_on_64bit_arch': 0,
118118
}],
@@ -420,10 +420,6 @@
420420
'cflags': [ '-m32' ],
421421
'ldflags': [ '-m32' ],
422422
}],
423-
[ 'target_arch=="x32"', {
424-
'cflags': [ '-mx32' ],
425-
'ldflags': [ '-mx32' ],
426-
}],
427423
[ 'target_arch=="x64"', {
428424
'cflags': [ '-m64' ],
429425
'ldflags': [ '-m64' ],

configure.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
valid_os = ('win', 'mac', 'solaris', 'freebsd', 'openbsd', 'linux',
4848
'android', 'aix', 'cloudabi')
4949
valid_arch = ('arm', 'arm64', 'ia32', 'mips', 'mipsel', 'mips64el', 'ppc',
50-
'ppc64', 'x32','x64', 'x86', 'x86_64', 's390x', 'riscv64')
50+
'ppc64', 'x64', 'x86', 'x86_64', 's390x', 'riscv64', 'loong64')
5151
valid_arm_float_abi = ('soft', 'softfp', 'hard')
5252
valid_arm_fpu = ('vfp', 'vfpv3', 'vfpv3-d16', 'neon')
5353
valid_mips_arch = ('loongson', 'r1', 'r2', 'r6', 'rx')

deps/openssl/config/Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ PERL = perl
1111
# Supported architecture list
1212
ASM_ARCHS = aix-gcc aix64-gcc BSD-x86 BSD-x86_64 \
1313
darwin64-x86_64-cc darwin-i386-cc darwin64-arm64-cc linux-aarch64 \
14-
linux-armv4 linux-elf linux-x32 linux-x86_64 linux-ppc \
14+
linux-armv4 linux-elf linux-x86_64 linux-ppc \
1515
linux-ppc64 linux-ppc64le linux32-s390x linux64-s390x linux64-mips64\
1616
solaris-x86-gcc solaris64-x86_64-gcc VC-WIN64A VC-WIN32
1717

deps/openssl/config/archs/linux-x32/asm/crypto/include/internal/bn_conf.h

-28
This file was deleted.

deps/openssl/config/archs/linux-x32/asm/crypto/include/internal/dso_conf.h

-17
This file was deleted.

deps/openssl/config/archs/linux-x32/asm/include/openssl/opensslconf.h

-200
This file was deleted.

deps/openssl/config/archs/linux-x32/asm_avx2/crypto/include/internal/bn_conf.h

-28
This file was deleted.

deps/openssl/config/archs/linux-x32/asm_avx2/crypto/include/internal/dso_conf.h

-17
This file was deleted.

0 commit comments

Comments
 (0)