Skip to content

Commit 42b4f3c

Browse files
bnoordhuisMylesBorins
authored andcommitted
src: fix abort when taking a heap snapshot
Remove an erroneous CHECK that asserted the persistent object's internal field pointer still pointed to a valid object. If ClearWrap() has been called, the field pointer equals nullptr and that is expected behavior. PR-URL: #18898 Fixes: #18256 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
1 parent 29c395d commit 42b4f3c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/async_wrap.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ RetainedObjectInfo* WrapperInfo(uint16_t class_id, Local<Value> wrapper) {
129129
CHECK_GT(object->InternalFieldCount(), 0);
130130

131131
AsyncWrap* wrap = Unwrap<AsyncWrap>(object);
132-
CHECK_NE(nullptr, wrap);
132+
if (wrap == nullptr) return nullptr; // ClearWrap() already called.
133133

134134
return new RetainedAsyncInfo(class_id, wrap);
135135
}

0 commit comments

Comments
 (0)