Skip to content

Commit 42be835

Browse files
author
Eugene Ostroukhov
committed
inspector: fix Coverity defects
PR-URL: #12272 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
1 parent b8f4160 commit 42be835

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/inspector_io.cc

+6-2
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ class DispatchOnInspectorBackendTask : public v8::Task {
155155

156156
InspectorIo::InspectorIo(Environment* env, v8::Platform* platform,
157157
const std::string& path, const DebugOptions& options)
158-
: options_(options), delegate_(nullptr),
158+
: options_(options), thread_(), delegate_(nullptr),
159159
shutting_down_(false), state_(State::kNew),
160160
parent_env_(env), io_thread_req_(),
161161
platform_(platform), dispatching_messages_(false),
@@ -236,6 +236,7 @@ void InspectorIo::WriteCbIO(uv_async_t* async) {
236236
template<typename Transport>
237237
void InspectorIo::WorkerRunIO() {
238238
uv_loop_t loop;
239+
loop.data = nullptr;
239240
int err = uv_loop_init(&loop);
240241
CHECK_EQ(err, 0);
241242
io_thread_req_.data = nullptr;
@@ -244,8 +245,11 @@ void InspectorIo::WorkerRunIO() {
244245
std::string script_path;
245246
if (!script_name_.empty()) {
246247
uv_fs_t req;
247-
if (0 == uv_fs_realpath(&loop, &req, script_name_.c_str(), nullptr))
248+
req.ptr = nullptr;
249+
if (0 == uv_fs_realpath(&loop, &req, script_name_.c_str(), nullptr)) {
250+
CHECK_NE(req.ptr, nullptr);
248251
script_path = std::string(static_cast<char*>(req.ptr));
252+
}
249253
uv_fs_req_cleanup(&req);
250254
}
251255
InspectorIoDelegate delegate(this, script_path, script_name_,

0 commit comments

Comments
 (0)