Skip to content

Commit 42cd952

Browse files
committed
deps: silence irrelevant V8 warning
PR-URL: #45579 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #47251 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Richard Lau <[email protected]> PR-URL: #49639 Reviewed-By: Antoine du Hamel <[email protected]>
1 parent 88cf90f commit 42cd952

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.1',
39+
'v8_embedder_string': '-node.2',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/include/v8-persistent-handle.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ class NonCopyablePersistentTraits {
241241
* This will clone the contents of storage cell, but not any of the flags, etc.
242242
*/
243243
template <class T>
244-
struct V8_DEPRECATED("Use v8::Global instead") CopyablePersistentTraits {
244+
struct CopyablePersistentTraits {
245245
using CopyablePersistent = Persistent<T, CopyablePersistentTraits<T>>;
246246
static const bool kResetInDestructor = true;
247247
template <class S, class M>

0 commit comments

Comments
 (0)