Skip to content

Commit 43ede1a

Browse files
cjihrigmarco-ippolito
authored andcommitted
test: mark 'test/parallel/test-sqlite.js' as flaky
The current test is large and can time out. It should be split into multiple smaller tests as done in #54014. However, that approach appears to change GC behavior such that the database files are not cleaned up quickly enough on Windows. Forcing any unfinalized SQL statements to be GC'ed appears to fix the problem. Mark the original test as flaky until the necessary code changes are made. PR-URL: #54031 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Richard Lau <[email protected]>
1 parent 0d70c79 commit 43ede1a

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

test/parallel/parallel.status

+3
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ test-fs-read-stream-concurrent-reads: PASS, FLAKY
1919
# https://github.com/nodejs/node/issues/52630
2020
test-error-serdes: PASS, FLAKY
2121

22+
# https://github.com/nodejs/node/issues/54006
23+
test-sqlite: PASS, FLAKY
24+
2225
[$system==win32]
2326

2427
# Windows on x86

0 commit comments

Comments
 (0)