Skip to content

Commit 44b9154

Browse files
committed
deps: switch to upstream v8_inspector
This change picks up v8_inspector directly from the upstream chromium repository [1]; dropping the intermediate repository. The upstream code has been refactored substantially to make it easy to share code without adaptation with Node.js. The deps/v8_inspector directory is now simply a gathering of dependencies: * platform/v8_inspector: vendored from [2]. * platform/inspector_protocol: vendored from [3]. * deps/jinja2: vendored from [4]. * deps/markupsafe: vendored from [5]. [1]: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform [2]: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform/v8_inspector [3]: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform/inspector_protocol [4]: https://github.com/mitsuhiko/jinja2 [5]: https://github.com/mitsuhiko/markupsafe PR-URL: #7302 Reviewed-By: indutny - Fedor Indutny <[email protected]> Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
1 parent 62a858c commit 44b9154

File tree

94 files changed

+4713
-11267
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

94 files changed

+4713
-11267
lines changed

configure

+1
Original file line numberDiff line numberDiff line change
@@ -816,6 +816,7 @@ def configure_node(o):
816816

817817
o['variables']['asan'] = int(options.enable_asan or 0)
818818
o['variables']['v8_inspector'] = b(not options.without_inspector)
819+
o['variables']['debug_devtools'] = 'node'
819820

820821
if options.use_xcode and options.use_ninja:
821822
raise Exception('--xcode and --ninja cannot be used together.')

deps/v8_inspector/README.md

+10-2
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,10 @@
1-
# v8_inspector
2-
# v8_inspector
1+
V8 Inspector support for Node.js
2+
================================
3+
4+
This directory is a gathering of dependencies for Node.js support for the
5+
[Chrome Debug Protocol][https://developer.chrome.com/devtools/docs/debugger-protocol].
6+
7+
* platform/v8_inspector: vendored from https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform/v8_inspector
8+
* platform/inspector_protocol: vendored from https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform/inspector_protocol
9+
* deps/jinja2: vendored from https://github.com/mitsuhiko/jinja2
10+
* deps/markupsafe: vendored from https://github.com/mitsuhiko/markupsafe

deps/v8_inspector/devtools/Inspector-1.1.json

-3,924
This file was deleted.

deps/v8_inspector/devtools/protocol.json

-5,167
This file was deleted.

deps/v8_inspector/platform/PlatformExport.h

-66
This file was deleted.

deps/v8_inspector/platform/inspector_protocol/Array.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
#ifndef Array_h
66
#define Array_h
77

8-
#include "platform/PlatformExport.h"
98
#include "platform/inspector_protocol/Collections.h"
109
#include "platform/inspector_protocol/ErrorSupport.h"
10+
#include "platform/inspector_protocol/Platform.h"
1111
#include "platform/inspector_protocol/String16.h"
1212
#include "platform/inspector_protocol/ValueConversions.h"
1313
#include "platform/inspector_protocol/Values.h"
@@ -91,7 +91,7 @@ class Array {
9191
errors->addError("array expected");
9292
return nullptr;
9393
}
94-
std::unique_ptr<Array<T>> result = wrapUnique(new Array<T>());
94+
std::unique_ptr<Array<T>> result(new Array<T>());
9595
errors->push();
9696
for (size_t i = 0; i < array->size(); ++i) {
9797
errors->setName(String16::number(i));
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
// Copyright (c) 2016 The Chromium Authors. All rights reserved.
2+
// Use of this source code is governed by a BSD-style license that can be
3+
// found in the LICENSE file.
4+
5+
#ifndef BackendCallback_h
6+
#define BackendCallback_h
7+
8+
#include "platform/inspector_protocol/ErrorSupport.h"
9+
#include "platform/inspector_protocol/Platform.h"
10+
11+
namespace blink {
12+
namespace protocol {
13+
14+
class PLATFORM_EXPORT BackendCallback {
15+
public:
16+
virtual ~BackendCallback() { }
17+
virtual void sendFailure(const ErrorString&) = 0;
18+
};
19+
20+
} // namespace platform
21+
} // namespace blink
22+
23+
#endif // !defined(BackendCallback_h)

deps/v8_inspector/platform/inspector_protocol/Backend_cpp.template

Whitespace-only changes.

deps/v8_inspector/platform/inspector_protocol/Backend_h.template

-78
This file was deleted.

0 commit comments

Comments
 (0)