Skip to content

Commit 44bcc1d

Browse files
jasnelltargos
authored andcommittedSep 3, 2018
test: fix cctest URLTest.ToFilePath on Win32 without Intl
Skip one specific test that requires ICU Fixes: #19051 PR-URL: #22265 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent dec42b5 commit 44bcc1d

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed
 

‎test/cctest/test_url.cc

+5
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,12 @@ TEST_F(URLTest, ToFilePath) {
8888
T("file:///C:/Program%20Files/", "C:\\Program Files\\");
8989
T("file:///C:/a/b/c?query#fragment", "C:\\a\\b\\c");
9090
T("file://host/path/a/b/c?query#fragment", "\\\\host\\path\\a\\b\\c");
91+
#if defined(NODE_HAVE_I18N_SUPPORT)
9192
T("file://xn--weird-prdj8vva.com/host/a", "\\\\wͪ͊eiͬ͋rd.com\\host\\a");
93+
#else
94+
T("file://xn--weird-prdj8vva.com/host/a",
95+
"\\\\xn--weird-prdj8vva.com\\host\\a");
96+
#endif
9297
T("file:///C:/a%2Fb", "");
9398
T("file:///", "");
9499
T("file:///home", "");

0 commit comments

Comments
 (0)