tools,lib,test: enable ESLint no-regex-spaces rule

PR-URL: #41463
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>

Author: Trott

.eslintrc.js

@@ -215,6 +215,7 @@ module.exports = {
     'no-path-concat': 'error',
     'no-proto': 'error',
     'no-redeclare': ['error', { 'builtinGlobals': false }],
+    'no-regex-spaces': 'error',
     'no-restricted-modules': ['error', 'sys'],
     /* eslint-disable max-len */
     'no-restricted-properties': [

lib/internal/util/inspect.js

@@ -188,7 +188,7 @@ const strEscapeSequencesReplacerSingle = /[\x00-\x1f\x5c\x7f-\x9f]|[\ud800-\udbf
 const keyStrRegExp = /^[a-zA-Z_][a-zA-Z_0-9]*$/;
 const numberRegExp = /^(0|[1-9][0-9]*)$/;
 
-const coreModuleRegExp = /^    at (?:[^/\\(]+ \(|)node:(.+):\d+:\d+\)?$/;
+const coreModuleRegExp = /^ {4}at (?:[^/\\(]+ \(|)node:(.+):\d+:\d+\)?$/;
 const nodeModulesRegExp = /[/\\]node_modules[/\\](.+?)(?=[/\\])/g;
 
 const classRegExp = /^(\s+[^(]*?)\s*{/;

test/parallel/test-assert-deep.js

@@ -1125,7 +1125,7 @@ assert.throws(
     {
       code: 'ERR_ASSERTION',
       name: 'AssertionError',
-      message: /a: \[Getter: 5]\n-   a: \[Getter: 6]\n  /
+      message: /a: \[Getter: 5]\n- {3}a: \[Getter: 6]\n {2}/
     }
   );
 

test/parallel/test-assert.js

@@ -1247,7 +1247,7 @@ assert.throws(
     assert.deepStrictEqual(Array(100).fill(1), 'foobar');
   } catch (err) {
     threw = true;
-    assert.match(inspect(err), /actual: \[Array],\n  expected: 'foobar',/);
+    assert.match(inspect(err), /actual: \[Array],\n {2}expected: 'foobar',/);
   }
   assert(threw);
 }

test/parallel/test-debugger-address.js

@@ -65,7 +65,7 @@ function launchTarget(...args) {
     .then(() => {
       assert.match(
         cli.output,
-        /> 3   \+\+x;/,
+        /> 3 {3}\+\+x;/,
         'marks the 3rd line');
     })
     .then(() => cleanup())

test/parallel/test-events-uncaught-exception-stack.js

@@ -9,7 +9,7 @@ process.on('uncaughtException', common.mustCall((err) => {
   const lines = err.stack.split('\n');
   assert.strictEqual(lines[0], 'Error');
   lines.slice(1).forEach((line) => {
-    assert.match(line, /^    at/);
+    assert.match(line, /^ {4}at/);
   });
 }));
 

test/parallel/test-http2-stream-client.js

@@ -12,9 +12,9 @@ server.on('stream', common.mustCall((stream) => {
   assert.strictEqual(stream.aborted, false);
   const insp = util.inspect(stream);
   assert.match(insp, /Http2Stream {/);
-  assert.match(insp, /  state:/);
-  assert.match(insp, /  readableState:/);
-  assert.match(insp, /  writableState:/);
+  assert.match(insp, / {2}state:/);
+  assert.match(insp, / {2}readableState:/);
+  assert.match(insp, / {2}writableState:/);
   stream.end('ok');
 }));
 server.listen(0, common.mustCall(() => {

test/parallel/test-repl-definecommand.js

@@ -35,7 +35,7 @@ r.defineCommand('say2', function() {
 });
 
 inputStream.write('.help\n');
-assert.match(output, /\n\.say1     help for say1\n/);
+assert.match(output, /\n\.say1 {5}help for say1\n/);
 assert.match(output, /\n\.say2\n/);
 inputStream.write('.say1 node developer\n');
 assert.ok(output.startsWith('hello node developer\n'),

test/parallel/test-repl-underscore.js

@@ -179,7 +179,7 @@ function testError() {
       // The sync error, with individual property echoes
       /^Uncaught Error: ENOENT: no such file or directory, scandir '.*nonexistent\?'/,
       /Object\.readdirSync/,
-      /^  errno: -(2|4058),$/,
+      /^ {2}errno: -(2|4058),$/,
       "  syscall: 'scandir',",
       "  code: 'ENOENT',",
       "  path: '/nonexistent?'",

test/parallel/test-repl.js

@@ -571,10 +571,10 @@ const errorTests = [
       /^Uncaught Error: Cannot find module 'internal\/repl'/,
       /^Require stack:/,
       /^- <repl>/,
-      /^    at .*/,
-      /^    at .*/,
-      /^    at .*/,
-      /^    at .*/,
+      /^ {4}at .*/,
+      /^ {4}at .*/,
+      /^ {4}at .*/,
+      /^ {4}at .*/,
       "  code: 'MODULE_NOT_FOUND',",
       "  requireStack: [ '<repl>' ]",
       '}',
@@ -776,12 +776,12 @@ const errorTests = [
       '  group: [Function: group],',
       '  groupEnd: [Function: groupEnd],',
       '  table: [Function: table],',
-      /  debug: \[Function: (debug|log)],/,
-      /  info: \[Function: (info|log)],/,
-      /  dirxml: \[Function: (dirxml|log)],/,
-      /  error: \[Function: (error|warn)],/,
-      /  groupCollapsed: \[Function: (groupCollapsed|group)],/,
-      /  Console: \[Function: Console],?/,
+      / {2}debug: \[Function: (debug|log)],/,
+      / {2}info: \[Function: (info|log)],/,
+      / {2}dirxml: \[Function: (dirxml|log)],/,
+      / {2}error: \[Function: (error|warn)],/,
+      / {2}groupCollapsed: \[Function: (groupCollapsed|group)],/,
+      / {2}Console: \[Function: Console],?/,
       ...process.features.inspector ? [
         '  profile: [Function: profile],',
         '  profileEnd: [Function: profileEnd],',

test/sequential/test-debugger-pid.js

@@ -44,7 +44,7 @@ function launchTarget(...args) {
     .then(() => {
       assert.match(
         cli.output,
-        /> 3   \+\+x;/,
+        /> 3 {3}\+\+x;/,
         'marks the 3rd line');
     })
     .then(() => cleanup())

test/tick-processor/test-tick-processor-unknown.js

@@ -14,7 +14,7 @@ const base = require('./tick-processor-base.js');
 // Unknown checked for to prevent flakiness, if pattern is not found,
 // then a large number of unknown ticks should be present
 base.runTest({
-  pattern: /LazyCompile.*\[eval]:1|.*%  UNKNOWN/,
+  pattern: /LazyCompile.*\[eval]:1|.*% {2}UNKNOWN/,
   code: `function f() {
            for (let i = 0; i < 1000000; i++) {
              i++;