@@ -734,17 +734,15 @@ int SyncProcessRunner::ParseOptions(Local<Value> js_value) {
734
734
}
735
735
Local<Value> js_uid = js_options->Get (env ()->uid_string ());
736
736
if (IsSet (js_uid)) {
737
- if (!js_uid->IsInt32 ())
738
- return UV_EINVAL;
737
+ CHECK (js_uid->IsInt32 ());
739
738
const int32_t uid = js_uid->Int32Value (env ()->context ()).FromJust ();
740
739
uv_process_options_.uid = static_cast <uv_uid_t >(uid);
741
740
uv_process_options_.flags |= UV_PROCESS_SETUID;
742
741
}
743
742
744
743
Local<Value> js_gid = js_options->Get (env ()->gid_string ());
745
744
if (IsSet (js_gid)) {
746
- if (!js_gid->IsInt32 ())
747
- return UV_EINVAL;
745
+ CHECK (js_gid->IsInt32 ());
748
746
const int32_t gid = js_gid->Int32Value (env ()->context ()).FromJust ();
749
747
uv_process_options_.gid = static_cast <uv_gid_t >(gid);
750
748
uv_process_options_.flags |= UV_PROCESS_SETGID;
@@ -760,28 +758,21 @@ int SyncProcessRunner::ParseOptions(Local<Value> js_value) {
760
758
761
759
Local<Value> js_timeout = js_options->Get (env ()->timeout_string ());
762
760
if (IsSet (js_timeout)) {
763
- if (!js_timeout->IsNumber ())
764
- return UV_EINVAL;
761
+ CHECK (js_timeout->IsNumber ());
765
762
int64_t timeout = js_timeout->IntegerValue ();
766
- if (timeout < 0 )
767
- return UV_EINVAL;
768
763
timeout_ = static_cast <uint64_t >(timeout);
769
764
}
770
765
771
766
Local<Value> js_max_buffer = js_options->Get (env ()->max_buffer_string ());
772
767
if (IsSet (js_max_buffer)) {
773
- if (!js_max_buffer->IsUint32 ())
774
- return UV_EINVAL;
768
+ CHECK (js_max_buffer->IsUint32 ());
775
769
max_buffer_ = js_max_buffer->Uint32Value ();
776
770
}
777
771
778
772
Local<Value> js_kill_signal = js_options->Get (env ()->kill_signal_string ());
779
773
if (IsSet (js_kill_signal)) {
780
- if (!js_kill_signal->IsInt32 ())
781
- return UV_EINVAL;
774
+ CHECK (js_kill_signal->IsInt32 ());
782
775
kill_signal_ = js_kill_signal->Int32Value ();
783
- if (kill_signal_ == 0 )
784
- return UV_EINVAL;
785
776
}
786
777
787
778
Local<Value> js_stdio = js_options->Get (env ()->stdio_string ());
0 commit comments