readline: cursorTo throw error on NaN

Fixes: #36301

PR-URL: #36379
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>

Author: Lxxyx

Diff for: lib/readline.js

@@ -1236,6 +1236,11 @@ function cursorTo(stream, x, y, callback) {
     y = undefined;
   }
 
+  if (NumberIsNaN(x))
+    throw new ERR_INVALID_ARG_VALUE('x', x);
+  if (NumberIsNaN(y))
+    throw new ERR_INVALID_ARG_VALUE('y', y);
+
   if (stream == null || (typeof x !== 'number' && typeof y !== 'number')) {
     if (typeof callback === 'function')
       process.nextTick(callback, null);

Diff for: test/parallel/test-readline-csi.js

@@ -161,3 +161,16 @@ assert.strictEqual(writable.data, '\x1b[2G');
 assert.throws(() => {
   readline.cursorTo(writable, 1, 1, null);
 }, /ERR_INVALID_CALLBACK/);
+
+// Verify that cursorTo() throws if x or y is NaN.
+assert.throws(() => {
+  readline.cursorTo(writable, NaN);
+}, /ERR_INVALID_ARG_VALUE/);
+
+assert.throws(() => {
+  readline.cursorTo(writable, 1, NaN);
+}, /ERR_INVALID_ARG_VALUE/);
+
+assert.throws(() => {
+  readline.cursorTo(writable, NaN, NaN);
+}, /ERR_INVALID_ARG_VALUE/);