Skip to content

Commit 46c9194

Browse files
cclausstargos
authored andcommitted
deps: V8: cherry-pick a7dffcd767be
Original commit message: [postmortem] Load files using utf-8 to support Python 3 Change-Id: I174d38cc33210c07d1a7596627e1b2d21bb06313 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1895560 Reviewed-by: Mathias Bynens <[email protected]> Commit-Queue: Michaël Zasso <[email protected]> Cr-Commit-Position: refs/heads/master@{#64717} Refs: v8/v8@a7dffcd PR-URL: #30218 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
1 parent 68e4b5a commit 46c9194

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939

4040
# Reset this number to 0 on major V8 upgrades.
4141
# Increment by one for each non-official patch applied to deps/v8.
42-
'v8_embedder_string': '-node.18',
42+
'v8_embedder_string': '-node.19',
4343

4444
##### V8 defaults for Node.js #####
4545

deps/v8/tools/gen-postmortem-metadata.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
# for py2/py3 compatibility
5050
from __future__ import print_function
5151

52+
import io
5253
import re
5354
import sys
5455

@@ -382,7 +383,7 @@ def load_objects():
382383

383384

384385
def load_objects_from_file(objfilename, checktypes):
385-
objfile = open(objfilename, 'r');
386+
objfile = io.open(objfilename, 'r', encoding='utf-8');
386387
in_insttype = False;
387388

388389
typestr = '';
@@ -577,7 +578,7 @@ def load_fields():
577578

578579

579580
def load_fields_from_file(filename):
580-
inlfile = open(filename, 'r');
581+
inlfile = io.open(filename, 'r', encoding='utf-8');
581582

582583
#
583584
# Each class's fields and the corresponding offsets are described in the

0 commit comments

Comments
 (0)