Skip to content

Commit 47366d7

Browse files
committed
deps: V8: extend workaround for MSVC optimizer bug
Builds are starting to fail in CI with V8 7.5 and 7.6. Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html PR-URL: #28286 Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent 8aeb9cc commit 47366d7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

deps/v8/src/builtins/setup-builtins-internal.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ Code GenerateBytecodeHandler(Isolate* isolate, int builtin_index,
297297

298298
} // namespace
299299

300-
#if _MSC_VER == 1920
300+
#ifdef _MSC_VER
301301
#pragma optimize( "", off )
302302
#endif
303303

@@ -384,7 +384,7 @@ void SetupIsolateDelegate::SetupBuiltinsInternal(Isolate* isolate) {
384384
builtins->MarkInitialized();
385385
}
386386

387-
#if _MSC_VER == 1920
387+
#ifdef _MSC_VER
388388
#pragma optimize( "", on )
389389
#endif
390390

0 commit comments

Comments
 (0)