fixup! deps: update c-ares to 1.24.0

Author: lpinca

deps/cares/cares.gyp

@@ -11,28 +11,39 @@
       'src/lib/ares__buf.c',
       'src/lib/ares__buf.h',
       'src/lib/ares__close_sockets.c',
+      'src/lib/ares__hosts_file.c',
       'src/lib/ares__htable.c',
       'src/lib/ares__htable.h',
       'src/lib/ares__htable_asvp.c',
       'src/lib/ares__htable_asvp.h',
-      'src/lib/ares__htable_stvp.c',
-      'src/lib/ares__htable_stvp.h',
+      'src/lib/ares__htable_strvp.c',
+      'src/lib/ares__htable_strvp.h',
+      'src/lib/ares__htable_szvp.c',
+      'src/lib/ares__htable_szvp.h',
+      'src/lib/ares__iface_ips.c',
+      'src/lib/ares__iface_ips.h',
       'src/lib/ares__llist.c',
       'src/lib/ares__llist.h',
-      'src/lib/ares__get_hostent.c',
       'src/lib/ares__parse_into_addrinfo.c',
       'src/lib/ares__read_line.c',
-      'src/lib/ares__readaddrinfo.c',
       'src/lib/ares__slist.c',
       'src/lib/ares__slist.h',
+      'src/lib/ares__socket.c',
       'src/lib/ares__sortaddrinfo.c',
+      'src/lib/ares__threads.c',
       'src/lib/ares__timeval.c',
       'src/lib/ares_android.c',
       'src/lib/ares_cancel.c',
       'src/lib/ares_create_query.c',
       'src/lib/ares_data.c',
       'src/lib/ares_data.h',
       'src/lib/ares_destroy.c',
+      'src/lib/ares_dns_mapping.c',
+      'src/lib/ares_dns_name.c',
+      'src/lib/ares_dns_parse.c',
+      'src/lib/ares_dns_record.c',
+      'src/lib/ares_dns_private.h',
+      'src/lib/ares_dns_write.c',
       'src/lib/ares_expand_name.c',
       'src/lib/ares_expand_string.c',
       'src/lib/ares_fds.c',
@@ -49,9 +60,8 @@
       'src/lib/ares_init.c',
       'src/lib/ares_ipv6.h',
       'src/lib/ares_library_init.c',
+      'src/lib/ares_math.c',
       'src/lib/ares_mkquery.c',
-      'src/lib/ares_nowarn.c',
-      'src/lib/ares_nowarn.h',
       'src/lib/ares_options.c',
       'src/lib/ares_parse_a_reply.c',
       'src/lib/ares_parse_aaaa_reply.c',
@@ -67,21 +77,23 @@
       'src/lib/ares_platform.h',
       'src/lib/ares_private.h',
       'src/lib/ares_process.c',
+      'src/lib/ares_qcache.c',
       'src/lib/ares_query.c',
       'src/lib/ares_rand.c',
       'src/lib/ares_search.c',
       'src/lib/ares_send.c',
       'src/lib/ares_setup.h',
       'src/lib/ares_strcasecmp.c',
       'src/lib/ares_strcasecmp.h',
-      'src/lib/ares_strdup.c',
-      'src/lib/ares_strdup.h',
+      'src/lib/ares_str.c',
+      'src/lib/ares_str.h',
       'src/lib/ares_strerror.c',
       'src/lib/ares_strsplit.c',
+      'src/lib/ares_sysconfig.c',
+      'src/lib/ares_sysconfig_files.c',
       'src/lib/ares_timeout.c',
+      'src/lib/ares_update_servers.c',
       'src/lib/ares_version.c',
-      'src/lib/bitncmp.c',
-      'src/lib/bitncmp.h',
       'src/lib/inet_net_pton.c',
       'src/lib/inet_ntop.c',
       'src/lib/setup_once.h',

test/parallel/test-dns-resolveany-bad-ancount.js

@@ -7,6 +7,8 @@ const dgram = require('dgram');
 const dnsPromises = dns.promises;
 
 const server = dgram.createSocket('udp4');
+const resolver = new dns.Resolver({ timeout: 100, tries: 1 });
+const resolverPromises = new dnsPromises.Resolver({ timeout: 100, tries: 1 });
 
 server.on('message', common.mustCall((msg, { address, port }) => {
   const parsed = dnstools.parseDNSPacket(msg);
@@ -18,16 +20,20 @@ server.on('message', common.mustCall((msg, { address, port }) => {
     questions: parsed.questions,
     answers: { type: 'A', address: '1.2.3.4', ttl: 123, domain },
   });
-  // Overwrite the # of answers with 2, which is incorrect.
+  // Overwrite the # of answers with 2, which is incorrect. The response is
+  // discarded in c-ares >= 1.21.0. This is the reason why a small timeout is
+  // used in the `Resolver` constructor. See
+  // https://github.com/nodejs/node/pull/50743#issue-1994909204
   buf.writeUInt16LE(2, 6);
   server.send(buf, port, address);
 }, 2));
 
 server.bind(0, common.mustCall(async () => {
   const address = server.address();
-  dns.setServers([`127.0.0.1:${address.port}`]);
+  resolver.setServers([`127.0.0.1:${address.port}`]);
+  resolverPromises.setServers([`127.0.0.1:${address.port}`]);
 
-  dnsPromises.resolveAny('example.org')
+  resolverPromises.resolveAny('example.org')
     .then(common.mustNotCall())
     .catch(common.expectsError({
       // May return EBADRESP or ETIMEOUT
@@ -36,7 +42,7 @@ server.bind(0, common.mustCall(async () => {
       hostname: 'example.org'
     }));
 
-  dns.resolveAny('example.org', common.mustCall((err) => {
+  resolver.resolveAny('example.org', common.mustCall((err) => {
     assert.notStrictEqual(err.code, 'SUCCESS');
     assert.strictEqual(err.syscall, 'queryAny');
     assert.strictEqual(err.hostname, 'example.org');