Skip to content

Commit 4831278

Browse files
targosnodejs-github-bot
authored andcommitted
url: remove U+0000 case in the fragment state
Port of whatwg/url#486 PR-URL: #33770 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
1 parent eb9d7a4 commit 4831278

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

src/node_url.cc

-2
Original file line numberDiff line numberDiff line change
@@ -2084,8 +2084,6 @@ void URL::Parse(const char* input,
20842084
url->flags |= URL_FLAGS_HAS_FRAGMENT;
20852085
url->fragment = std::move(buffer);
20862086
break;
2087-
case 0:
2088-
break;
20892087
default:
20902088
AppendOrEscape(&buffer, ch, FRAGMENT_ENCODE_SET);
20912089
}

test/wpt/status/url.json

-3
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@
1212
"idlharness.any.js": {
1313
"fail": "getter/setter names are wrong, etc."
1414
},
15-
"url-setters-stripping.any.js": {
16-
"fail": "TODO: port https://github.com/whatwg/url/pull/486"
17-
},
1815
"urlsearchparams-constructor.any.js": {
1916
"fail": "TODO: fix https://github.com/nodejs/node/issues/33892"
2017
},

0 commit comments

Comments
 (0)