Skip to content

Commit 48ab7dc

Browse files
Matheus MarchiniMylesBorins
Matheus Marchini
authored andcommitted
deps: cherry-pick 804a693 from upstream V8
Original commit message: [postmortem] add JS_ERROR_TYPE and context embedder index * JS_ERROR_TYPE is required for postmortem tools to inspect JSError objects (see nodejs/llnode#215 for a usage example) * The context embedder index is required for postmortem tools to access embedder data stored in the context (see nodejs/llnode#204 for a usage example) [email protected], [email protected] Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25 Reviewed-on: https://chromium-review.googlesource.com/1138493 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/master@{#54475} Refs: v8/v8@804a693 Backport-PR-URL: #21668 PR-URL: #21855 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]>
1 parent eb9850a commit 48ab7dc

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929

3030
# Reset this number to 0 on major V8 upgrades.
3131
# Increment by one for each non-official patch applied to deps/v8.
32-
'v8_embedder_string': '-node.11',
32+
'v8_embedder_string': '-node.12',
3333

3434
# Enable disassembler for `--print-code` v8 options
3535
'v8_enable_disassembler': 1,

deps/v8/tools/gen-postmortem-metadata.py

+5
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,9 @@
211211
'value': 'Context::EXTENSION_INDEX' },
212212
{ 'name': 'context_min_slots',
213213
'value': 'Context::MIN_CONTEXT_SLOTS' },
214+
{ 'name': 'context_idx_embedder_data',
215+
'value': 'Internals::kContextEmbedderDataIndex' },
216+
214217

215218
{ 'name': 'namedictionaryshape_prefix_size',
216219
'value': 'NameDictionaryShape::kPrefixSize' },
@@ -231,6 +234,8 @@
231234
'value': 'SimpleNumberDictionaryShape::kPrefixSize' },
232235
{ 'name': 'simplenumberdictionaryshape_entry_size',
233236
'value': 'SimpleNumberDictionaryShape::kEntrySize' },
237+
238+
{ 'name': 'type_JSError__JS_ERROR_TYPE', 'value': 'JS_ERROR_TYPE' },
234239
];
235240

236241
#

0 commit comments

Comments
 (0)