Skip to content

Commit 4958501

Browse files
addaleaxtargos
authored andcommitted
test: remove timeout from test-pipe-stream
The timeout is unnecessary and the suspected cause of the following failure (even though I could not reproduce it locally): 11:53:54 not ok 197 parallel/test-pipe-stream 11:53:54 --- 11:53:54 duration_ms: 6.253 11:53:54 severity: fail 11:53:54 exitcode: 1 11:53:54 stack: |- 11:53:54 assert.js:338 11:53:54 throw err; 11:53:54 ^ 11:53:54 11:53:54 AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value: 11:53:54 11:53:54 assert.ok(have_ping) 11:53:54 11:53:54 at check (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:14:12) 11:53:54 at Server.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:61:5) 11:53:54 at Server.emit (events.js:182:13) 11:53:54 at emitCloseNT (net.js:1668:8) 11:53:54 at process._tickCallback (internal/process/next_tick.js:63:19) (From https://ci.nodejs.org/job/node-test-binary-arm/2235/RUN_SUBSET=5,label=pi3-docker/console.) PR-URL: #21837 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent f6606bf commit 4958501

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

test/parallel/test-pipe-stream.js

-5
Original file line numberDiff line numberDiff line change
@@ -49,15 +49,10 @@ function test(clazz, cb) {
4949
});
5050
}
5151

52-
const timeout = setTimeout(function() {
53-
server.close();
54-
}, 2000);
55-
5652
const server = net.Server();
5753
server.listen(common.PIPE, ping);
5854
server.on('connection', pong);
5955
server.on('close', function() {
60-
clearTimeout(timeout);
6156
check();
6257
cb && cb();
6358
});

0 commit comments

Comments
 (0)