Skip to content

Commit 4996056

Browse files
danbevrvagg
authored andcommitted
crypto: add SET_INTEGER_CONSANT macro
This commit introduces a SET_INTEGER_CONSANT macro to reduce some code duplication in SecureContext::Initialize. PR-URL: #23687 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
1 parent 34d9129 commit 4996056

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

src/node_crypto.cc

+10-10
Original file line numberDiff line numberDiff line change
@@ -469,16 +469,16 @@ void SecureContext::Initialize(Environment* env, Local<Object> target) {
469469
env->SetProtoMethod(t, "getCertificate", SecureContext::GetCertificate<true>);
470470
env->SetProtoMethod(t, "getIssuer", SecureContext::GetCertificate<false>);
471471

472-
t->Set(FIXED_ONE_BYTE_STRING(env->isolate(), "kTicketKeyReturnIndex"),
473-
Integer::NewFromUnsigned(env->isolate(), kTicketKeyReturnIndex));
474-
t->Set(FIXED_ONE_BYTE_STRING(env->isolate(), "kTicketKeyHMACIndex"),
475-
Integer::NewFromUnsigned(env->isolate(), kTicketKeyHMACIndex));
476-
t->Set(FIXED_ONE_BYTE_STRING(env->isolate(), "kTicketKeyAESIndex"),
477-
Integer::NewFromUnsigned(env->isolate(), kTicketKeyAESIndex));
478-
t->Set(FIXED_ONE_BYTE_STRING(env->isolate(), "kTicketKeyNameIndex"),
479-
Integer::NewFromUnsigned(env->isolate(), kTicketKeyNameIndex));
480-
t->Set(FIXED_ONE_BYTE_STRING(env->isolate(), "kTicketKeyIVIndex"),
481-
Integer::NewFromUnsigned(env->isolate(), kTicketKeyIVIndex));
472+
#define SET_INTEGER_CONSTANTS(name, value) \
473+
t->Set(FIXED_ONE_BYTE_STRING(env->isolate(), name), \
474+
Integer::NewFromUnsigned(env->isolate(), value));
475+
SET_INTEGER_CONSTANTS("kTicketKeyReturnIndex", kTicketKeyReturnIndex);
476+
SET_INTEGER_CONSTANTS("kTicketKeyHMACIndex", kTicketKeyHMACIndex);
477+
SET_INTEGER_CONSTANTS("kTicketKeyAESIndex", kTicketKeyAESIndex);
478+
SET_INTEGER_CONSTANTS("kTicketKeyNameIndex", kTicketKeyNameIndex);
479+
SET_INTEGER_CONSTANTS("kTicketKeyIVIndex", kTicketKeyIVIndex);
480+
481+
#undef SET_INTEGER_CONSTANTS
482482

483483
Local<FunctionTemplate> ctx_getter_templ =
484484
FunctionTemplate::New(env->isolate(),

0 commit comments

Comments
 (0)