Skip to content

Commit 4a49707

Browse files
danbevMylesBorins
authored andcommitted
crypto: remove BIO_set_shutdown
I've not been able to find any reason for calling BIO_set_shutdown(bio, 1). This is done by default for the following versions of OpenSSL: https://github.com/openssl/openssl/blob/OpenSSL_1_1_0/ crypto/bio/bio_lib.c#L26 https://github.com/openssl/openssl/blob/OpenSSL_1_0_1/ crypto/bio/bio_lib.c#L90 https://github.com/openssl/openssl/blob/OpenSSL_1_0_2/ crypto/bio/bio_lib.c#L88 https://github.com/openssl/openssl/blob/OpenSSL_1_0_0/ crypto/bio/bio_lib.c#L90 This commit removes the call and the comment. PR-URL: #17542 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent 30bfd6f commit 4a49707

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/node_crypto_bio.cc

-2
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,6 @@ void NodeBIO::AssignEnvironment(Environment* env) {
6868
int NodeBIO::New(BIO* bio) {
6969
BIO_set_data(bio, new NodeBIO());
7070

71-
// XXX Why am I doing it?!
72-
BIO_set_shutdown(bio, 1);
7371
BIO_set_init(bio, 1);
7472

7573
return 1;

0 commit comments

Comments
 (0)