Skip to content

Commit 4c57272

Browse files
committed
test: skip stringbytes-external-exceed-max on AIX
Add SKIP status for more tests in stringbytes-external-exceed-max that are failing on AIX.
1 parent 39a9358 commit 4c57272

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

test/addons/addon.status

+12
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
prefix addons
2+
3+
[true] # This section applies to all platforms
4+
5+
[$system==aix]
6+
# https://github.com/nodejs/build/issues/1820#issuecomment-505998851
7+
# https://github.com/nodejs/node/pull/28469
8+
# https://github.com/nodejs/node/pull/28516
9+
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js: SKIP
10+
11+
# https://github.com/nodejs/node/pull/28516
12+
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-hex: SKIP

test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js

-5
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,6 @@ const skipMessage = 'intensive toString tests due to memory confinements';
55
if (!common.enoughTestMem)
66
common.skip(skipMessage);
77

8-
// See https://github.com/nodejs/build/issues/1820#issuecomment-505998851
9-
// See https://github.com/nodejs/node/pull/28469
10-
if (process.platform === 'aix')
11-
common.skip('flaky on AIX');
12-
138
const binding = require(`./build/${common.buildType}/binding`);
149

1510
// v8 fails silently if string length > v8::String::kMaxLength

0 commit comments

Comments
 (0)