Skip to content

Commit 4e742e3

Browse files
Trotttargos
authored andcommitted
tools: update tooling to work with new macOS CLI …
Using High Sierra and `xcode-select --install` without installing full Xcode, our build tooling breaks due to faulty regular expressions. Update the `configure` script in our project root directory to handle multi-digit version numbers. `tools/gyp` and `deps/npm/node_modules/node-gyp` still need to be updated for a complete fix. PR-URL: #21173 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 78c7d66 commit 4e742e3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

configure

+1-1
Original file line numberDiff line numberDiff line change
@@ -667,7 +667,7 @@ def get_llvm_version(cc):
667667

668668
def get_xcode_version(cc):
669669
return get_version_helper(
670-
cc, r"(^Apple LLVM version) ([5-9]\.[0-9]+)")
670+
cc, r"(^Apple LLVM version) ([0-9]+\.[0-9]+)")
671671

672672
def get_gas_version(cc):
673673
try:

0 commit comments

Comments
 (0)