Skip to content

Commit 4eb8810

Browse files
committed
tls: re-enable .writev() on TLSWrap
Fix the `parallel/test-tls-over-http-tunnel.js` on Windows by re-enabling the accidentally disabled `.writev()` method on TLSWrap. It appears that there is some subtle issue with shutdown timing and it manifests itself when the chunks are written in separate packets. This leads to concurrent `shutdown`/`destroy`, which breaks the test. PR-URL: #1155 Reviewed-By: Bert Belder <[email protected]>
1 parent e90ed79 commit 4eb8810

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/tls_wrap.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -827,7 +827,7 @@ void TLSWrap::Initialize(Handle<Object> target,
827827
env->SetProtoMethod(t, "enableSessionCallbacks", EnableSessionCallbacks);
828828
env->SetProtoMethod(t, "enableHelloParser", EnableHelloParser);
829829

830-
StreamBase::AddMethods<TLSWrap>(env, t);
830+
StreamBase::AddMethods<TLSWrap>(env, t, StreamBase::kFlagHasWritev);
831831
SSLWrap<TLSWrap>::AddMethods(env, t);
832832

833833
#ifdef SSL_CTRL_SET_TLSEXT_SERVERNAME_CB

0 commit comments

Comments
 (0)