Skip to content

Commit 4f13ac7

Browse files
gengjiawencodebytere
authored andcommitted
console: improve code readability
use object spread to make console code more readable PR-URL: #24412 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent b61a51c commit 4f13ac7

File tree

1 file changed

+16
-13
lines changed

1 file changed

+16
-13
lines changed

lib/console.js

+16-13
Original file line numberDiff line numberDiff line change
@@ -86,23 +86,26 @@ function Console(options /* or: stdout, stderr, ignoreErrors = true */) {
8686
throw new ERR_CONSOLE_WRITABLE_STREAM('stderr');
8787
}
8888

89-
var prop = {
89+
const prop = {
9090
writable: true,
9191
enumerable: false,
9292
configurable: true
9393
};
94-
prop.value = stdout;
95-
Object.defineProperty(this, '_stdout', prop);
96-
prop.value = stderr;
97-
Object.defineProperty(this, '_stderr', prop);
98-
prop.value = Boolean(ignoreErrors);
99-
Object.defineProperty(this, '_ignoreErrors', prop);
100-
prop.value = new Map();
101-
Object.defineProperty(this, '_times', prop);
102-
prop.value = createWriteErrorHandler(stdout);
103-
Object.defineProperty(this, '_stdoutErrorHandler', prop);
104-
prop.value = createWriteErrorHandler(stderr);
105-
Object.defineProperty(this, '_stderrErrorHandler', prop);
94+
Object.defineProperty(this, '_stdout', { ...prop, value: stdout });
95+
Object.defineProperty(this, '_stderr', { ...prop, value: stderr });
96+
Object.defineProperty(this, '_ignoreErrors', {
97+
...prop,
98+
value: Boolean(ignoreErrors),
99+
});
100+
Object.defineProperty(this, '_times', { ...prop, value: new Map() });
101+
Object.defineProperty(this, '_stdoutErrorHandler', {
102+
...prop,
103+
value: createWriteErrorHandler(stdout),
104+
});
105+
Object.defineProperty(this, '_stderrErrorHandler', {
106+
...prop,
107+
value: createWriteErrorHandler(stderr),
108+
});
106109

107110
if (typeof colorMode !== 'boolean' && colorMode !== 'auto')
108111
throw new ERR_INVALID_ARG_VALUE('colorMode', colorMode);

0 commit comments

Comments
 (0)