Skip to content

Commit 4f3c9e6

Browse files
Vasili Skurydzinrvagg
Vasili Skurydzin
authored andcommitted
deps,v8: fix gyp build on Aix platform
Floating this patch since the code does not exist upstream anymore. deps/v8/testing/gtest.gyp: Supperss -Wnonnull-compare, -Waddress warnings for deps/v8/testing/gtest project; deps/v8/src/compiler/store-store-elimination.cc, deps/v8/src/conversions.cc: Suppress unused function warnings in order to compile with newer (>4.8.5) gcc on Aix. PR-URL: #23958 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: George Adams <[email protected]>
1 parent 5034729 commit 4f3c9e6

File tree

4 files changed

+17
-1
lines changed

4 files changed

+17
-1
lines changed

deps/v8/include/v8-version.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#define V8_MAJOR_VERSION 6
1212
#define V8_MINOR_VERSION 2
1313
#define V8_BUILD_NUMBER 414
14-
#define V8_PATCH_LEVEL 74
14+
#define V8_PATCH_LEVEL 75
1515

1616
// Use 1 for candidates and 0 otherwise.
1717
// (Boolean macro values are not supported by all preprocessors.)

deps/v8/src/compiler/store-store-elimination.cc

+6
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,9 @@ void StoreStoreElimination::Run(JSGraph* js_graph, Zone* temp_zone) {
251251
}
252252
}
253253

254+
#if V8_OS_AIX
255+
ALLOW_UNUSED_TYPE
256+
#endif
254257
bool RedundantStoreFinder::IsEffectful(Node* node) {
255258
return (node->op()->EffectInputCount() >= 1);
256259
}
@@ -552,6 +555,9 @@ bool UnobservableStore::operator==(const UnobservableStore other) const {
552555
return (id_ == other.id_) && (offset_ == other.offset_);
553556
}
554557

558+
#if V8_OS_AIX
559+
ALLOW_UNUSED_TYPE
560+
#endif
555561
bool UnobservableStore::operator!=(const UnobservableStore other) const {
556562
return !(*this == other);
557563
}

deps/v8/src/conversions.cc

+6
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,17 @@ class StringCharacterStreamIterator {
5353
};
5454

5555

56+
#if V8_OS_AIX
57+
ALLOW_UNUSED_TYPE
58+
#endif
5659
StringCharacterStreamIterator::StringCharacterStreamIterator(
5760
StringCharacterStream* stream) : stream_(stream) {
5861
++(*this);
5962
}
6063

64+
#if V8_OS_AIX
65+
ALLOW_UNUSED_TYPE
66+
#endif
6167
uint16_t StringCharacterStreamIterator::operator*() const {
6268
return current_;
6369
}

deps/v8/testing/gtest.gyp

+4
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,10 @@
9696
}],
9797
],
9898
}],
99+
['OS=="aix"', {
100+
'cflags': [ '-Wno-nonnull-compare',
101+
'-Wno-address' ],
102+
}],
99103
],
100104
'msvs_disabled_warnings': [4800],
101105
},

0 commit comments

Comments
 (0)