Revert "net: remove unnecessary process.nextTick()"

This reverts commit 571882c.

Removing the process.nextTick() call can prevent the consumer
from being able to catch error events.

PR-URL: #12854
Fixes: #12841
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>

Author: evanlucas

lib/net.js

@@ -1036,7 +1036,10 @@ function lookupAndConnect(self, options) {
   // If host is an IP, skip performing a lookup
   var addressType = cares.isIP(host);
   if (addressType) {
-    internalConnect(self, host, port, addressType, localAddress, localPort);
+    nextTick(self[async_id_symbol], function() {
+      if (self.connecting)
+        internalConnect(self, host, port, addressType, localAddress, localPort);
+    });
     return;
   }
 

test/async-hooks/test-tcpwrap.js

@@ -48,13 +48,16 @@ const server = net
     { port: server.address().port, host: server.address().address },
     common.mustCall(onconnected));
   const tcps = hooks.activitiesOfTypes('TCPWRAP');
-  const tcpconnects = hooks.activitiesOfTypes('TCPCONNECTWRAP');
   assert.strictEqual(
     tcps.length, 2,
     '2 TCPWRAPs present when client is connecting');
-  assert.strictEqual(
-    tcpconnects.length, 1,
-    '1 TCPCONNECTWRAP present when client is connecting');
+  process.nextTick(() => {
+    const tcpconnects = hooks.activitiesOfTypes('TCPCONNECTWRAP');
+    assert.strictEqual(
+      tcpconnects.length, 1,
+      '1 TCPCONNECTWRAP present when client is connecting');
+  });
+
   tcp2 = tcps[1];
   assert.strictEqual(tcps.length, 2,
                      '2 TCPWRAP present when client is connecting');