Skip to content

Commit 512a0cc

Browse files
targosMylesBorins
authored andcommitted
deps: V8: cherry-pick 53e62af
Original commit message: [build] Include string in v8.h Explicitly #include<string> in v8.h, since std::string is referenced in it. In the C++ STL shipped with Visual Studio 2019, none of the headers included in v8.h ends up including the C++ string header, which caused a compile error. Bug: v8:9793 Change-Id: I84a133dd10dd6dcc7b70287af393e82cf0dc97df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1834321 Reviewed-by: Adam Klein <[email protected]> Commit-Queue: Adam Klein <[email protected]> Cr-Commit-Position: refs/heads/master@{#64074} Refs: v8/v8@53e62af PR-URL: #29898 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
1 parent b6e892b commit 512a0cc

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.21',
41+
'v8_embedder_string': '-node.22',
4242

4343
##### V8 defaults for Node.js #####
4444

deps/v8/include/v8.h

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
#include <stdint.h>
2020
#include <stdio.h>
2121
#include <memory>
22+
#include <string>
2223
#include <type_traits>
2324
#include <utility>
2425
#include <vector>

0 commit comments

Comments
 (0)