Skip to content

Commit 5209ff9

Browse files
danbevtargos
authored andcommitted
src: remove unused fields msg_ and env_
Currently the following compiler warnings are generated: ../src/node_messaging.cc:74:16: warning: private field 'env_' is not used [-Wunused-private-field] Environment* env_; ^ ../src/node_messaging.cc:75:12: warning: private field 'msg_' is not used [-Wunused-private-field] Message* msg_; ^ 2 warnings generated. This commit removes these unused private members. PR-URL: #20876 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
1 parent d1f372f commit 5209ff9

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

src/node_messaging.cc

+1-5
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,7 @@ class DeserializerDelegate : public ValueDeserializer::Delegate {
4747
const std::vector<MessagePort*>& message_ports,
4848
const std::vector<Local<SharedArrayBuffer>>&
4949
shared_array_buffers)
50-
: env_(env),
51-
msg_(m),
52-
message_ports_(message_ports),
50+
: message_ports_(message_ports),
5351
shared_array_buffers_(shared_array_buffers) {}
5452

5553
MaybeLocal<Object> ReadHostObject(Isolate* isolate) override {
@@ -71,8 +69,6 @@ class DeserializerDelegate : public ValueDeserializer::Delegate {
7169
ValueDeserializer* deserializer = nullptr;
7270

7371
private:
74-
Environment* env_;
75-
Message* msg_;
7672
const std::vector<MessagePort*>& message_ports_;
7773
const std::vector<Local<SharedArrayBuffer>>& shared_array_buffers_;
7874
};

0 commit comments

Comments
 (0)