Skip to content

Commit 528edb2

Browse files
addaleaxgibfahn
authored andcommitted
build: ignore empty folders in test-addons-napi
The same as #16031 except for N-API addons. PR-URL: #16380 Fixes: #13521 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
1 parent a628455 commit 528edb2

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

Makefile

+6-1
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,8 @@ test/addons/.buildstamp: config.gypi \
299299
test/addons/.docbuildstamp
300300
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before
301301
# embedded addons have been generated from the documentation.
302-
# Ignore folders without binding.gyp (#14843)
302+
# Ignore folders without binding.gyp
303+
# (https://github.com/nodejs/node/issues/14843)
303304
@for dirname in test/addons/*/; do \
304305
if [ ! -f "$$PWD/$${dirname}binding.gyp" ]; then \
305306
continue; fi ; \
@@ -337,7 +338,11 @@ test/addons-napi/.buildstamp: config.gypi \
337338
src/node_api.h src/node_api_types.h
338339
# Cannot use $(wildcard test/addons-napi/*/) here, it's evaluated before
339340
# embedded addons have been generated from the documentation.
341+
# Ignore folders without binding.gyp
342+
# (https://github.com/nodejs/node/issues/14843)
340343
@for dirname in test/addons-napi/*/; do \
344+
if [ ! -f "$$PWD/$${dirname}binding.gyp" ]; then \
345+
continue; fi ; \
341346
printf "\nBuilding addon $$PWD/$$dirname\n" ; \
342347
env MAKEFLAGS="-j1" $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp \
343348
--loglevel=$(LOGLEVEL) rebuild \

0 commit comments

Comments
 (0)